lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] mm: zpool: Constify the zpool_ops
On Fri, Jul 3, 2015 at 5:40 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> The structure zpool_ops is not modified so make the pointer to it as
> pointer to const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Acked-by: Dan Streetman <ddstreet@ieee.org>

> ---
> include/linux/zpool.h | 4 ++--
> mm/zbud.c | 4 ++--
> mm/zpool.c | 4 ++--
> mm/zsmalloc.c | 3 ++-
> mm/zswap.c | 2 +-
> 5 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/zpool.h b/include/linux/zpool.h
> index d30eff3d84d5..c924a28d9805 100644
> --- a/include/linux/zpool.h
> +++ b/include/linux/zpool.h
> @@ -37,7 +37,7 @@ enum zpool_mapmode {
> };
>
> struct zpool *zpool_create_pool(char *type, char *name,
> - gfp_t gfp, struct zpool_ops *ops);
> + gfp_t gfp, const struct zpool_ops *ops);
>
> char *zpool_get_type(struct zpool *pool);
>
> @@ -81,7 +81,7 @@ struct zpool_driver {
> atomic_t refcount;
> struct list_head list;
>
> - void *(*create)(char *name, gfp_t gfp, struct zpool_ops *ops,
> + void *(*create)(char *name, gfp_t gfp, const struct zpool_ops *ops,
> struct zpool *zpool);
> void (*destroy)(void *pool);
>
> diff --git a/mm/zbud.c b/mm/zbud.c
> index f3bf6f7627d8..6f8158d64864 100644
> --- a/mm/zbud.c
> +++ b/mm/zbud.c
> @@ -99,7 +99,7 @@ struct zbud_pool {
> struct zbud_ops *ops;
> #ifdef CONFIG_ZPOOL
> struct zpool *zpool;
> - struct zpool_ops *zpool_ops;
> + const struct zpool_ops *zpool_ops;
> #endif
> };
>
> @@ -138,7 +138,7 @@ static struct zbud_ops zbud_zpool_ops = {
> };
>
> static void *zbud_zpool_create(char *name, gfp_t gfp,
> - struct zpool_ops *zpool_ops,
> + const struct zpool_ops *zpool_ops,
> struct zpool *zpool)
> {
> struct zbud_pool *pool;
> diff --git a/mm/zpool.c b/mm/zpool.c
> index 722a4f60e90b..951db32b833f 100644
> --- a/mm/zpool.c
> +++ b/mm/zpool.c
> @@ -22,7 +22,7 @@ struct zpool {
>
> struct zpool_driver *driver;
> void *pool;
> - struct zpool_ops *ops;
> + const struct zpool_ops *ops;
>
> struct list_head list;
> };
> @@ -115,7 +115,7 @@ static void zpool_put_driver(struct zpool_driver *driver)
> * Returns: New zpool on success, NULL on failure.
> */
> struct zpool *zpool_create_pool(char *type, char *name, gfp_t gfp,
> - struct zpool_ops *ops)
> + const struct zpool_ops *ops)
> {
> struct zpool_driver *driver;
> struct zpool *zpool;
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 0a7f81aa2249..6e139d381d80 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -309,7 +309,8 @@ static void record_obj(unsigned long handle, unsigned long obj)
>
> #ifdef CONFIG_ZPOOL
>
> -static void *zs_zpool_create(char *name, gfp_t gfp, struct zpool_ops *zpool_ops,
> +static void *zs_zpool_create(char *name, gfp_t gfp,
> + const struct zpool_ops *zpool_ops,
> struct zpool *zpool)
> {
> return zs_create_pool(name, gfp);
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 2d5727baed59..017a3f50725d 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -816,7 +816,7 @@ static void zswap_frontswap_invalidate_area(unsigned type)
> zswap_trees[type] = NULL;
> }
>
> -static struct zpool_ops zswap_zpool_ops = {
> +static const struct zpool_ops zswap_zpool_ops = {
> .evict = zswap_writeback_entry
> };
>
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-07-15 19:21    [W:2.453 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site