lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] i8042: Add unmask_kbd_data option
Hi Stephen,

On Thu, Jul 02, 2015 at 11:46:48AM -0400, cpaul@redhat.com wrote:
> +static int i8042_kbd_bind_notifier(struct notifier_block *nb,
> + unsigned long action, void *data)
> +{
> + struct device *dev = data;
> + struct serio *serio = to_serio_port(dev);
> + struct i8042_port *port = serio->port_data;
> +
> + if (serio != i8042_ports[I8042_KBD_PORT_NO].serio)
> + return 0;
> +
> + switch (action) {
> + case BUS_NOTIFY_BOUND_DRIVER:
> + port->driver_bound = true;
> + break;
> +
> + case BUS_NOTIFY_UNBOUND_DRIVER:

I think it should be BUS_NOTIFY_UNBIND_DRIVER so that we see the KBD
data as it goes through driver cleanup. Yell if you disagree, or I'll
change it locally.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2015-07-15 19:21    [W:0.077 / U:1.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site