Messages in this thread | | | Date | Thu, 16 Jul 2015 02:38:00 +0000 (UTC) | From | Paul Walmsley <> | Subject | Re: [PATCH v2 2/6] ARM: AM43xx: Add the PRM IRQ register offsets |
| |
On Thu, 16 Jul 2015, Paul Walmsley wrote:
> On Wed, 8 Jul 2015, Keerthy wrote: > > > Add the PRM IRQ register offsets. > > > > Signed-off-by: Keerthy <j-keerthy@ti.com> > > Please add more detail to your commit messages so they conform to > Documentation/SubmittingPatches: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n109 > > For example, this commit message should read something like: > > --- > > ARM: AM43xx: Add the PRM IRQ register offsets > > Add the PRM IRQ register offsets. This is needed to support PRM I/O > wakeup on AM43xx. > > -- > > Basically, your patches need to provide context as to _why_ the change is > needed. > > I've fixed the message for this patch, and queued it for v4.3, but > please take care with this issue in the future.
Also I've moved the AM43XX_PRM_IO_PMCTRL_OFFSET macro out of the AM43XX CM section, since it doesn't belong there.
- Paul
| |