Messages in this thread Patch in this message | | | From | Yinghai Lu <> | Subject | [PATCH v2 44/49] PCI: Don't release sibiling bridge resources during hotplug | Date | Tue, 14 Jul 2015 15:47:15 -0700 |
| |
On hotplug path, we can not touch sibling bridges that is out side of the slot.
That could happen when BIOS does not assign some bridge BARs and later can not assign resource to them in first try.
Check if fail dev is the parent bridge, then just use subordinate bus instead use parent bus.
Reported-by: Andreas Noever <andreas.noever@gmail.com> Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- drivers/pci/setup-bus.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 7ffb113..dc9ba41 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -2397,10 +2397,16 @@ again: * Try to release leaf bridge's resources that doesn't fit resource of * child device under that bridge */ - list_for_each_entry(fail_res, &fail_head, list) - pci_bus_release_bridge_resources(fail_res->dev->bus, + list_for_each_entry(fail_res, &fail_head, list) { + struct pci_bus *bus = fail_res->dev->bus; + + if (fail_res->dev == bridge) + bus = bridge->subordinate; + + pci_bus_release_bridge_resources(bus, fail_res->flags & type_mask, whole_subtree); + } /* restore size and flags */ list_for_each_entry(fail_res, &fail_head, list) { -- 1.8.4.5
| |