Messages in this thread | | | Date | Tue, 14 Jul 2015 14:41:13 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore |
| |
On 07/14/2015 02:22 PM, Oleg Nesterov wrote: >> Using my little write-1-byte test (under will-it-scale), your 4 patches >> improves the number of writes/sec by 12%. My 3 patches improve the >> number of writes/sec by 32%.
I looked at it again. I tested with this patch in addition to the ones modifying __sb_start/end_write():
https://lkml.org/lkml/2015/6/24/682
That is where the performance delta came from. Your patches (plus the fsnotify optimization) perform very similarly to my approach.
Yours remove so much code that I think they are the preferable approach.
They don't compile with lockdep on, btw. :)
| |