Messages in this thread | | | Date | Tue, 14 Jul 2015 14:56:19 +0800 | From | "Wangnan (F)" <> | Subject | Re: [PATCH 14/39] perf tools: Auto detecting kernel build directory |
| |
On 2015/7/14 5:46, Arnaldo Carvalho de Melo wrote: > Em Thu, Jul 09, 2015 at 12:35:17PM +0000, Wang Nan escreveu: >> This patch detects kernel build directory using a embedded shell >> script 'kbuild_detector', which does this by checking existence of >> include/generated/autoconf.h. >> >> clang working directory is changed to kbuild directory if it is found, >> to help user use relative include path. Following patch will detect >> kernel include directory, which contains relative include patch so this >> workdir changing is needed. >> >> Users are allowed to set 'kbuild-dir = ""' manually to disable this >> checking. > What is the advantage of doing this using a hardcoded shell script, > pipes, etc? Why not plain use some asprintf() for the pathnames to be > tested, then check those, etc in plain C? > > I have applied everything up to 13/39, provided some coments to the > others, will continue later today/tomorrow. > > Pushing what I have to perf/ebpf in my tree, > > Ah, please try, in your csets, to add the CC entries for the people you > CC when posting the patches to lkml, so that, when I pull from your > tree and then push to Ingo, people get notified, i.e. to follow the > style we use in tip/ branches. > > Right now I am cherry-picking, but at some point I would like to do > direct pulls. > > Thanks, > > - Arnaldo >
Thanks to your reply. I have accepted all of your advise and updated my csets:
1. Don't use script to check kbuild dir. Instead, use asprintf() + access();
2. Add CCs in each patches. Commit message of the top two patches in your perf/ebpf is updated.
Other changes including:
3. Simplify test__llvm using asprintf();
4. Bugfix: 'bpf tools: Load a program with different instances using preprocessor': 1. Add missing '!'; 2. Allows bpf_program__unload() before the program is loaded to suppress warning message in 'perf test 38'.
The following changes since commit 101ef9b4f5c70dbfffa0186102c1014bd81a4ec7:
bpf tools: Link all bpf objects onto a list (2015-07-13 18:48:17 -0300)
are available in the git repository at:
https://github.com/WangNan0/linux.git perf/ebpf-for-acme
for you to fetch changes up to d7425110530a9457f55a44ac01ab81558a5a5cca:
perf tools: Support attach BPF program on uprobe events (2015-07-14 06:40:11 +0000)
Thank you.
| |