lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] change get_super_thawed() to use sb_start/end_write()
On 07/14, Jan Kara wrote:
>
> > @@ -621,8 +621,8 @@ struct super_block *get_super_thawed(struct block_device *bdev)
> > if (!s || s->s_writers.frozen == SB_UNFROZEN)
> > return s;
> > up_read(&s->s_umount);
> > - wait_event(s->s_writers.wait_unfrozen,
> > - s->s_writers.frozen == SB_UNFROZEN);
> > + sb_start_write(s);
> > + sb_end_intwrite(s);
>
> This is definitely buggy - you need to start and end freeze protection at
> the same level...

Of course ;) copy-and-paste bug. Thanks!

Oleg.



\
 
 \ /
  Last update: 2015-07-14 16:01    [W:0.051 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site