Messages in this thread | | | Date | Tue, 14 Jul 2015 15:38:25 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/4] change get_super_thawed() to use sb_start/end_write() |
| |
On 07/14, Jan Kara wrote: > > > @@ -621,8 +621,8 @@ struct super_block *get_super_thawed(struct block_device *bdev) > > if (!s || s->s_writers.frozen == SB_UNFROZEN) > > return s; > > up_read(&s->s_umount); > > - wait_event(s->s_writers.wait_unfrozen, > > - s->s_writers.frozen == SB_UNFROZEN); > > + sb_start_write(s); > > + sb_end_intwrite(s); > > This is definitely buggy - you need to start and end freeze protection at > the same level...
Of course ;) copy-and-paste bug. Thanks!
Oleg.
| |