lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function


On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote:
>> + i2c->reg_base = devm_ioremap_resource(&dev->dev, res);
>> + if (IS_ERR(i2c->reg_base)) {
>> + dev_err(&dev->dev, "failed to map resource: %ld\n",
>> + PTR_ERR(i2c->reg_base));
>> + return PTR_ERR(i2c->reg_base);
>> + }
>
> One change I did when applying: removed this error message.
> devm_ioremap_resource prints out the errors it finds.
>

devm_ioremap_resource doesn't print return value.

So this additional error message would print one of, -EINVAL, -EBUSY
or -ENOMEM.

That was the reason I kept it.

If you feel it is not required, I am OK to remove it.

Thanks for the update, it certainly saved one more version :) .

Thanks,
Vaibhav


\
 
 \ /
  Last update: 2015-07-14 14:01    [W:0.181 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site