lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data
On 2015/7/14 13:28, Ilia Mirkin wrote:
>
> On Jul 13, 2015 4:42 PM, "Thomas Gleixner" <tglx@linutronix.de
> <mailto:tglx@linutronix.de>> wrote:
>>
>> It's pretty silly to do
>>
>> irq_data *d = irq_get_irq_data(irq_data->irq);
>>
>> because that results in d = irq_data, but goes through a lookup of the
>> irq_data. Use irq_data directly.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de
> <mailto:tglx@linutronix.de>>
>> Cc: Linus Walleij <linus.walleij@linaro.org
> <mailto:linus.walleij@linaro.org>>
>> Cc: Alexandre Courbot <gnurou@gmail.com <mailto:gnurou@gmail.com>>
>> Cc: Jiang Liu <jiang.liu@linux.intel.com
> <mailto:jiang.liu@linux.intel.com>>
>> Cc: linux-gpio@vger.kernel.org <mailto:linux-gpio@vger.kernel.org>
>> ---
>> drivers/gpio/gpio-msm-v2.c | 18 +++++-------------
>> 1 file changed, 5 insertions(+), 13 deletions(-)
>>
>> Index: tip/drivers/gpio/gpio-msm-v2.c
>> ===================================================================
>> --- tip.orig/drivers/gpio/gpio-msm-v2.c
>> +++ tip/drivers/gpio/gpio-msm-v2.c
>> @@ -187,14 +187,6 @@ static int msm_gpio_to_irq(struct gpio_c
>> return irq_create_mapping(domain, offset);
>> }
>>
>> -static inline int msm_irq_to_gpio(struct gpio_chip *chip, unsigned irq)
>> -{
>> - struct irq_data *irq_data = irq_get_irq_data(irq);
>> -
>> - return irq_data->hwirq;
>> -}
>> -
>> -
>> /* For dual-edge interrupts in software, since the hardware has no
>> * such support:
>> *
>> @@ -238,7 +230,7 @@ static void msm_gpio_update_dual_edge_po
>>w
>> static void msm_gpio_irq_ack(struct irq_data *d)
>> {
>> - int gpio = msm_irq_to_gpio(&msm_gpio.gpio_chip, d->irq);
>> + int gpio = d->hw_irq;
>
> Does this build? It was hwirq above, not hw_irq.

Yeah, should be hwirq.


\
 
 \ /
  Last update: 2015-07-14 08:01    [W:0.150 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site