lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 2/4] drm/panel: simple: Add support for NEC NL4827HC19-05B 480x272 panel
On Mon, Jul 13, 2015 at 06:51:30PM +0800, Jianwei Wang wrote:
> This adds support for the NEC NL4827HC19-05B 480x272 panel to the DRM
> simple panel driver.
>
> Signed-off-by: Alison Wang <b18965@freescale.com>
> Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
> Signed-off-by: Jianwei Wang <jianwei.wang@freescale.com>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> .../bindings/panel/nec,nl4827hc19_05b.txt | 7 ++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> MAINTAINERS | 1 -
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++
> 4 files changed, 34 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
>
> diff --git a/Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt b/Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
> new file mode 100644
> index 0000000..20e9473
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
> @@ -0,0 +1,7 @@
> +NEC LCD Technologies,Ltd. WQVGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "nec,nl4827hc19_05b"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 8033919..9f22b3e 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -131,6 +131,7 @@ mundoreader Mundo Reader S.L.
> murata Murata Manufacturing Co., Ltd.
> mxicy Macronix International Co., Ltd.
> national National Semiconductor
> +nec NEC LCD Technologies, Ltd.
> neonode Neonode Inc.
> netgear NETGEAR
> netlogic Broadcom Corporation (formerly NetLogic Microsystems)

This belongs in a separate patch.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index fffb8c9..e191ded 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3410,7 +3410,6 @@ M: Alison Wang <alison.wang@freescale.com>
> L: dri-devel@lists.freedesktop.org
> S: Supported
> F: drivers/gpu/drm/fsl-dcu/
> -F: Documentation/devicetree/bindings/drm/fsl-dcu/

What's this doing here?

> F: Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
>
> DRM DRIVERS FOR NVIDIA TEGRA
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index f94201b..eb12fe4 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1036,6 +1036,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
> .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> };
>
> +static const struct drm_display_mode nec_nl4827hc19_05b_mode = {
> + .clock = 10870,
> + .hdisplay = 480,
> + .hsync_start = 480 + 2,
> + .hsync_end = 480 + 2 + 41,
> + .htotal = 480 + 2 + 41 + 2,
> + .vdisplay = 272,
> + .vsync_start = 272 + 2,
> + .vsync_end = 272 + 2 + 4,
> + .vtotal = 272 + 2 + 4 + 2,
> + .vrefresh = 74,
> +};
> +
> +static const struct panel_desc nec_nl4827hc19_05b = {
> + .modes = &nec_nl4827hc19_05b_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 95,
> + .height = 54,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24
> +};
> +

Please keep these...

> static const struct of_device_id platform_of_match[] = {
> {
> .compatible = "ampire,am800480r3tmqwa1h",
> @@ -1125,6 +1148,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "shelly,sca07010-bfn-lnn",
> .data = &shelly_sca07010_bfn_lnn,
> }, {
> + .compatible = "nec,nl4827hc19_05b",
> + .data = &nec_nl4827hc19_05b,
> + }, {

and this sorted alphabetically.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-07-14 13:21    [W:0.092 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site