Messages in this thread | | | Date | Tue, 14 Jul 2015 12:08:44 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] aic7xxx: replace kmalloc/strcpy by kstrdup |
| |
On Tue, Jul 14, 2015 at 09:25:16AM +0200, Christophe JAILLET wrote: > --- a/drivers/scsi/aic7xxx/aic79xx_osm.c > +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c > @@ -1250,9 +1250,8 @@ ahd_linux_register_host(struct ahd_softc *ahd, struct scsi_host_template *templa > ahd_set_unit(ahd, ahd_linux_unit++); > ahd_unlock(ahd, &s); > sprintf(buf, "scsi%d", host->host_no); > - new_name = kmalloc(strlen(buf) + 1, GFP_ATOMIC); > + new_name = kstrdup(buf, GFP_ATOMIC); > if (new_name != NULL) { > - strcpy(new_name, buf); > ahd_set_name(ahd, new_name); > }
Remove the curly braces. And below as well.
regards, dan carpenter
| |