Messages in this thread | | | Date | Tue, 14 Jul 2015 10:30:30 +0200 | From | Ralf Baechle <> | Subject | Re: [PATCH 1/2] MIPS: PCI: ops-emma2rh: drop nonsensical db_assert |
| |
On Mon, Jul 13, 2015 at 05:14:21PM +0100, Paul Burton wrote:
> The db_assert call checks whether the bus_num pointer is non-NULL, but > does so after said pointer has been dereferenced by the assignment on > the previous line. Thus the check is pointless & likely to have been > optimised out by the compiler anyway. The check_args function is static > & only ever called from the local file with bus_num being a pointer to > an on-stack variable, so the check seems somewhat overzealous anyway. > Simply remove it.
Thanks, applied.
Your patch btw. leaves the db_verify() macro as the sole caller of db_assert() and db_verify() itself is unused and in fact, nothing includes <asm/debug.h> anymore. Removing <asm/debug.h> leaves CONFIG_RUNTIME_DEBUG unused, so I'm removing that one, too.
Ralf
| |