lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] MIPS: PCI: ops-emma2rh: drop nonsensical db_assert
On Mon, Jul 13, 2015 at 05:14:21PM +0100, Paul Burton wrote:

> The db_assert call checks whether the bus_num pointer is non-NULL, but
> does so after said pointer has been dereferenced by the assignment on
> the previous line. Thus the check is pointless & likely to have been
> optimised out by the compiler anyway. The check_args function is static
> & only ever called from the local file with bus_num being a pointer to
> an on-stack variable, so the check seems somewhat overzealous anyway.
> Simply remove it.

Thanks, applied.

Your patch btw. leaves the db_verify() macro as the sole caller of
db_assert() and db_verify() itself is unused and in fact, nothing
includes <asm/debug.h> anymore. Removing <asm/debug.h> leaves
CONFIG_RUNTIME_DEBUG unused, so I'm removing that one, too.

Ralf


\
 
 \ /
  Last update: 2015-07-14 11:01    [W:0.035 / U:0.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site