Messages in this thread | | | Date | Mon, 13 Jul 2015 14:24:12 +0200 | Subject | Re: [PATCH v3 1/4] gpio: brcmstb: fix null ptr dereference in driver remove | From | Linus Walleij <> |
| |
On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong <gregory.0xf0@gmail.com> wrote:
> If a failure occurs during probe, brcmstb_gpio_remove() is called. In > remove, we call platform_get_drvdata(), but at the time of failure in > the probe the driver data hadn't yet been set which leads to a NULL > ptr dereference in the remove's list_for_each. Call > platform_set_drvdata() and set up list head right after allocating the > priv struct to both avoid the null pointer dereference that could > occur today. To guard against potential future changes, check for > null pointer in remove. > > Reported-by: Tim Ross <tross@broadcom.com> > Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com> > --- > New in v3.
Patch applied.
Yours, Linus Walleij
| |