[lkml]   [2015]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC] freeing unlinked file indefinitely delayed
On Wed, Jul 08, 2015 at 10:41:43AM -0500, Ben Myers wrote:

> The bug rings a bell for me so I will stick my neck out instead of
> lurking. Don't you need to sample that link count under the filesystems
> internal lock in order to avoid an unlink/iget race? I suggest creating
> a helper to prune disconnected dentries which a filesystem could call in
> .unlink. That would avoid the risk of unintended side effects with the
> d_alloc/d_free/icache approach and have provable link count correctness.

For one thing, this patch does *not* check for i_nlink at all. For another,
there's no such thing as 'filesystems internal lock' for i_nlink protection -
that's handled by i_mutex... And what does iget() have to do with any of that?

 \ /
  Last update: 2015-07-12 17:21    [W:0.094 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site