Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH v2 3/4] media: pxa_camera: trivial move of dma irq functions | Date | Sun, 12 Jul 2015 16:32:27 +0200 |
| |
Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
>> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c >> index c0c0f0f..1ab4f9d 100644 >> --- a/drivers/media/platform/soc_camera/pxa_camera.c >> +++ b/drivers/media/platform/soc_camera/pxa_camera.c >> @@ -311,6 +311,28 @@ static int calculate_dma_sglen(struct scatterlist *sglist, int sglen, >> >> BUG_ON(size != 0); >> return i + 1; >> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev, >> + enum pxa_camera_active_dma act_dma); > > Yes, functions look ok now as the sense - they are just moved up with no > modifications, but the patch itself looks as broken to me as it originally > was... Please, look 2 lines up - where you add your lines. Indeed. I don't know how that could happen. I would have sworn they were in the correct place, then I rebased / solved conflicts, and ... messed up.
That would be for the v3, and I'll inspect the mails before sending.
Cheers.
-- Robert
| |