Messages in this thread | | | Date | Sat, 11 Jul 2015 14:17:49 -0400 | Subject | Re: [PATCH] drm/atomic: fix null dereference | From | Rob Clark <> |
| |
On Sat, Jul 11, 2015 at 1:24 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > We are checking the size of e->event but we were doing it when e is > known to be NULL.
nak, this will leak event_space.. since it is a sizeof, it isn't actually deref'ing e, but rather just using the static type info, so it's ok (although perhaps funny looking)
BR, -R
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/gpu/drm/drm_atomic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index acebd16..51d3a85 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -1311,7 +1311,6 @@ static struct drm_pending_vblank_event *create_vblank_event( > e = kzalloc(sizeof *e, GFP_KERNEL); > if (e == NULL) { > spin_lock_irqsave(&dev->event_lock, flags); > - file_priv->event_space += sizeof e->event; > spin_unlock_irqrestore(&dev->event_lock, flags); > goto out; > } > -- > 1.8.1.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
| |