Messages in this thread | | | Date | Wed, 1 Jul 2015 23:07:23 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 45/51] writeback: implement wb_wait_for_single_work() |
| |
Hello,
On Wed, Jul 01, 2015 at 09:07:35PM +0200, Jan Kara wrote: > I don't understand, why is the special handling with single_wait, > single_done necessary. When we fail to allocate work and thus use the > base_work for submission, we can still use the standard completion mechanism > to wait for work to finish, can't we?
Indeed. I'm not sure why I didn't do that. I'll try.
> BTW: Again it would be easier for me to review this if the implementation > of this function was in one patch with the use of it so that one can see > how it gets used...
Same point on this one as before.
Thanks.
-- tejun
| |