Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v1 10/10] core: platform: use fwnode_driver_match_device() | Date | Thu, 02 Jul 2015 01:46:19 +0200 |
| |
On Tuesday, June 30, 2015 04:55:08 PM Tomeu Vizoso wrote: > Instead of calling both of_driver_match_device() and > acpi_driver_match_device(), call fwnode_driver_match_device() which > should be able to sort out what firmware describes the device in > question. > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
This one should be part of the other set IMO.
Or please just combine the two sets so it is more clear what the new helpers are intended for.
> --- > > drivers/base/platform.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 063f0ab..a7e7757 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -843,12 +843,8 @@ static int platform_match(struct device *dev, struct device_driver *drv) > if (pdev->driver_override) > return !strcmp(pdev->driver_override, drv->name); > > - /* Attempt an OF style match first */ > - if (of_driver_match_device(dev, drv)) > - return 1; > - > - /* Then try ACPI style match */ > - if (acpi_driver_match_device(dev, drv)) > + /* Attempt a firmware match first */ > + if (fwnode_driver_match_device(dev, drv)) > return 1; > > /* Then try to match against the id table */ >
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |