lkml.org 
[lkml]   [2015]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting
    Hi Peter,

    On 06/29/2015 06:31 PM, Peter Hung wrote:
    > The temperature value of Fintek F81866 is the same with
    > f71882fg. It located with 0x6c + 2*(nr), others located
    > with 0x6c + 2*(nr+1). We change the rule in f71882fg_probe(),
    > If type = f71858fg/f8000/f81866a. the temp_start will set to 0,
    > others are 1.
    >
    > The F81866 over-temperature beep setting is not the same with
    > f71882fg too. They are using the same address 63H, but F81866 is
    > using bit 0/1/2 & 4/5/6, others are using bit 1/2/3 & 5/6/7,
    > So we copy from fxxxx_temp_beep_attr[] to f81866_temp_beep_attr
    > and change bit setting.
    >
    > Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
    > ---
    [ .. ]

    > + if (data->type == f81866a) {
    > + size = ARRAY_SIZE(f81866_temp_beep_attr[0]);
    > + err = f71882fg_create_sysfs_files(pdev,
    > + &f81866_temp_beep_attr[0][0],
    > + size * nr_temps);
    > +
    > + } else {
    > + size = ARRAY_SIZE(fxxxx_temp_beep_attr[0];

    TskTsk ... turns out you didn't even compile test this code.

    How am I supposed to know that it is working ?

    Guenter



    \
     
     \ /
      Last update: 2015-07-01 23:21    [W:3.141 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site