Messages in this thread | | | Subject | Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue | From | Joe Perches <> | Date | Wed, 01 Jul 2015 08:08:05 -0700 |
| |
On Wed, 2015-07-01 at 17:31 +0300, Dan Carpenter wrote: > On Wed, Jul 01, 2015 at 07:17:58PM +0530, Sohny Thomas wrote: > > > > As per checkpatch.pl remove unnecessary typedef > > Here ion_user_handle_t was used only in the header . > > > > Signed-of-by: Sohny Thomas <sohnythomas@zoho.com> > > The original code was correct.
because the typedef is exposed to user-space. (uapi)
> Checkpatch.pl is not the king of the > world, which you must obey or die.
As Dan once said, "it's less sentient than a squirrel".
> It is just a perl script.
Don't be a squirrel. Please engage your brain when using the stupid little tool.
| |