lkml.org 
[lkml]   [2015]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] backlight: lp8788: Deletion of a check before backlight_device_unregister()
    On Sun, 28 Jun 2015, SF Markus Elfring wrote:

    > > From: Markus Elfring <elfring@users.sourceforge.net>
    > >
    > > The backlight_device_unregister() function tests whether its argument is NULL
    > > and then returns immediately. Thus the test around the call is not needed.
    > >
    > > This issue was detected by using the Coccinelle software.
    > >
    > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > > ---
    > > drivers/video/backlight/lp8788_bl.c | 3 +--
    > > 1 file changed, 1 insertion(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
    > > index d6c4f6a..24a055c 100644
    > > --- a/drivers/video/backlight/lp8788_bl.c
    > > +++ b/drivers/video/backlight/lp8788_bl.c
    > > @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl)
    > > {
    > > struct backlight_device *bl_dev = bl->bl_dev;
    > >
    > > - if (bl_dev)
    > > - backlight_device_unregister(bl_dev);
    > > + backlight_device_unregister(bl_dev);
    > > }
    > >
    > > static ssize_t lp8788_get_bl_ctl_mode(struct device *dev,
    > >
    >
    > Would you like to integrate this update suggestion
    > into another source code repository?

    If this patch has not received any attention in some time, it's
    possible that it may have slipped through the gaps. Please
    re-submit the set.

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog


    \
     
     \ /
      Last update: 2015-07-01 10:21    [W:4.029 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site