Messages in this thread |  | | Date | Tue, 9 Jun 2015 22:09:23 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCHv3] perf stat: Add id into perf_stat struct |
| |
On Mon, Jun 08, 2015 at 11:03:40AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 04, 2015 at 03:50:55PM +0200, Jiri Olsa escreveu: > > On Wed, Jun 03, 2015 at 04:25:51PM +0200, Jiri Olsa wrote: > > > We need fast way to identify evsel as transaction event > > > for shadow counters computation. Currently we are using > > > possition (in evlist) based way. > > > > > > Adding 'id' into 'struct perf_stat' so it can carry transaction > > > event ID and we can use it for shadow counters computations. > > > > > > Link: http://lkml.kernel.org/n/tip-9lnvjksibrs0flhkpix2qkm9@git.kernel.org > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > > --- > > > > using perf_evsel__name instead of evsel->name pointer > > It now passes 'perf test' on rhel7/fedora21 systems, but it fails on a > rhel6 system, I applied it, will test it further on the rhel6 system to > see what went wrong there, unless you do it first ;-) > > [root@sandy ~]# perf test 15 > 15: struct perf_event_attr setup :sh: line > 1: 5381 Aborted (core dumped) > PERF_TEST_ATTR=/tmp/tmp8ZBLwc /home/acme/bin/perf stat -o > /tmp/tmp8ZBLwc/perf.data --group -e cycles,instructions kill > /dev/null > 2>&1 > sh: line 1: 5438 Aborted (core dumped) > PERF_TEST_ATTR=/tmp/tmpnRDADB /home/acme/bin/perf stat -o > /tmp/tmpnRDADB/perf.data -e '{cycles,instructions}' kill > /dev/null > 2>&1 > Ok > [root@sandy ~]# uname -r > 2.6.32-504.8.1.el6.x86_64 > [root@sandy ~]# cat /etc/redhat-release > Red Hat Enterprise Linux Server release 6.6 (Santiago) > [root@sandy ~]#
hum, cant reproduce
[root@ibm-x3650m4-02 perf]# ./perf test 15 15: struct perf_event_attr setup : Ok
the server is latest rhel6 kernel (scratch):
[root@ibm-x3650m4-02 perf]# uname -a Linux ibm-x3650m4-02.lab.eng.brq.redhat.com 2.6.32-556.el6perf_ivb_haswell_1.x86_64 #1 SMP Wed Apr 29 06:00:24 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux [root@ibm-x3650m4-02 perf]# cat /etc/redhat-release Red Hat Enterprise Linux Server release 6.6 (Santiago)
jirka
|  |