Messages in this thread |  | | Date | Tue, 9 Jun 2015 10:57:56 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2 4/8] input: goodix: reset device at init |
| |
Hi Irina,
On Mon, Jun 08, 2015 at 05:37:49PM +0300, Irina Tirdea wrote: > +static int goodix_get_gpio_config(struct goodix_ts_data *ts) > +{ > + struct device *dev; > + struct gpio_desc *gpiod; > + int ret; > + > + if (!ts->client) > + return -EINVAL; > + dev = &ts->client->dev; > + > + /* Get interrupt GPIO pin number */ > + gpiod = devm_gpiod_get(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN); > + if (IS_ERR(gpiod)) { > + ret = PTR_ERR(gpiod); > + dev_err(dev, "Failed to get %s GPIO: %d\n", > + GOODIX_GPIO_INT_NAME, ret);
You need to handle -EPROBE_DEFER (suppress error) and especially -ENOENT error codes, otherwise, as Bastien mentioned, you will break existing DTS.
Thanks.
-- Dmitry
|  |