Messages in this thread | | | Subject | Re: [PATCH -next] selftests/ipc: Consolidate posix and sysv msg queue tests | From | Davidlohr Bueso <> | Date | Tue, 09 Jun 2015 09:23:23 -0700 |
| |
On Tue, 2015-06-09 at 06:55 -0600, Shuah Khan wrote > > diff --git a/tools/testing/selftests/ipc/.gitignore b/tools/testing/selftests/ipc/.gitignore > > new file mode 100644 > > index 0000000..3d8a449 > > --- /dev/null > > +++ b/tools/testing/selftests/ipc/.gitignore > > @@ -0,0 +1,3 @@ > > +mqueue/mq_open_tests > > +mqueue/mq_perf_tests > > +msg/msgque_test > > diff --git a/tools/testing/selftests/ipc/Makefile b/tools/testing/selftests/ipc/Makefile > > index 25d2e70..8686551 100644 > > --- a/tools/testing/selftests/ipc/Makefile > > +++ b/tools/testing/selftests/ipc/Makefile > > @@ -1,22 +1,22 @@ > > -uname_M := $(shell uname -m 2>/dev/null || echo not) > > -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) > > -ifeq ($(ARCH),i386) > > - ARCH := x86 > > - CFLAGS := -DCONFIG_X86_32 -D__i386__ > > -endif > > -ifeq ($(ARCH),x86_64) > > - ARCH := x86 > > - CFLAGS := -DCONFIG_X86_64 -D__x86_64__ > > -endif > > - > > -CFLAGS += -I../../../../usr/include/ > > Hmm. This looks like more than a moving code and cleanup change. > The above is removing special handling for x86 and x86_64. > > I would like to see this as a separate patch and not combined > with the moving code.
No, this is merely being moved to msg/Makefile, see below:
> diff --git a/tools/testing/selftests/ipc/msg/Makefile b/tools/testing/selftests/ipc/msg/Makefile > new file mode 100644 > index 0000000..777ca76 > --- /dev/null > +++ b/tools/testing/selftests/ipc/msg/Makefile > @@ -0,0 +1,22 @@ > +uname_M := $(shell uname -m 2>/dev/null || echo not) > +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) > +ifeq ($(ARCH),i386) > + ARCH := x86 > + CFLAGS := -DCONFIG_X86_32 -D__i386__ > +endif > +ifeq ($(ARCH),x86_64) > + ARCH := x86 > + CFLAGS := -DCONFIG_X86_64 -D__x86_64__ > +endif
Thanks, Davidlohr
| |