lkml.org 
[lkml]   [2015]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] spi: mediatek: Add spi bus for Mediatek MT8173
On Tue, Jun 09, 2015 at 06:05:21PM +0800, Eddie Huang wrote:

> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -539,8 +539,8 @@ static int __spi_map_msg(struct spi_master *master,
> struct spi_message *msg)
> if (!master->can_dma)
> return 0;

> - tx_dev = master->dma_tx->device->dev;
> - rx_dev = master->dma_rx->device->dev;
> + tx_dev = master->dma_tx ? master->dma_tx->device->dev :
> master->dev;
> + rx_dev = master->dma_rx ? master->dma_rx->device->dev : master-

> Is this what you want ? Actually, I don't like first one at all.

Not quite what I'd been thinking of - we can't just pick the device in
the core safely, the device might be a MFD or have some other
restriction that needs us to use a separate struct device. However most
of those cases are likely to point towards implementing a dmaengine
device so probably the above will work for most cases and is fine. Can
you send a proper patch please?

Please don't use the ternery operator, though.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-06-09 13:01    [W:0.124 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site