[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: lustre: question about lov_request.c

On Jun 8, 2015, at 3:24 AM, Julia Lawall wrote:

>> You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now,
>> so it's safe to drop the whole if and also the struct member itself.
>> set_oabufs could be dropped as well.
> Looking further, in the same function I also don't see any other uses of
> the tested field in:
> if (req->rq_oi.oi_md)
> OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);
> if (set->set_lockh)
> lov_llh_put(set->set_lockh);
> Can these be dropped as well?

Yes, these two seems to be on their way out too, so please feel free to remove them.



 \ /
  Last update: 2015-06-08 10:21    [W:0.097 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site