lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 08/13] KVM: implement multiple address spaces


On 05/28/2015 01:05 AM, Paolo Bonzini wrote:

> /*
> @@ -772,6 +776,7 @@ int __kvm_set_memory_region(struct kvm *kvm,
> struct kvm_memory_slot *slot;
> struct kvm_memory_slot old, new;
> struct kvm_memslots *slots = NULL, *old_memslots;
> + int as_id, id;
> enum kvm_mr_change change;
>
> r = check_memory_region_flags(mem);
> @@ -779,24 +784,27 @@ int __kvm_set_memory_region(struct kvm *kvm,
> goto out;
>
> r = -EINVAL;
> + as_id = mem->slot >> 16;
> + id = mem->slot & 65535;
> +

A minor comment, Could you put these decoding into a separate function?

Nice idea indeed.

Reviewed-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>


\
 
 \ /
  Last update: 2015-06-09 05:41    [W:0.280 / U:1.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site