lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/15] KVM: MTRR: introduce var_mtrr_range

Thanks for your review, David!


On 06/09/2015 08:36 AM, David Matlack wrote:

>> static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>> {
>> struct kvm_mtrr *mtrr_state = &vcpu->arch.mtrr_state;
>> - gfn_t start, end, mask;
>> + gfn_t start, end;
>> int index;
>>
>> if (msr == MSR_IA32_CR_PAT || !tdp_enabled ||
>> @@ -244,11 +255,7 @@ static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>> default:
>> /* variable range MTRRs. */
>> index = (msr - 0x200) / 2;
>> - start = mtrr_state->var_ranges[index].base & PAGE_MASK;
>> - mask = mtrr_state->var_ranges[index].mask & PAGE_MASK;
>> - mask |= ~0ULL << cpuid_maxphyaddr(vcpu);
>
> Why did you drop this in favor of boot_cpu_data.x86_phys_bits?
>

It can make the code more generic, @vcpu is not needed anymore.


\
 
 \ /
  Last update: 2015-06-09 05:21    [W:0.066 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site