lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/6] power: hibernate: Use separate messages for "Syncing filesystems"
    Date
    On Thursday, June 04, 2015 11:36:44 AM Joe Perches wrote:
    > Add the ability to see how long it takes to sync the filesystems
    > via the printk time mechanism.
    >
    > Start to standardize the printk "PM: doing something...done"
    > messages on two separate lines.

    Well, it would be good to say what problem this is attempting to fix.

    And while I understand the underlying concern, there is a merit in keeping
    each of these messages in one line (if everything goes well), so I'm wondering
    what about printing each of them in one go after the operation with a tail
    depending on the result? Like

    printk(KERN_INFO "PM: Syncing filesystems ... done\n");

    on success or

    printk(KERN_INFO "PM: Syncing filesystems ... failed\n");

    on failure?


    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    > kernel/power/hibernate.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
    > index 2329daa..2466d78 100644
    > --- a/kernel/power/hibernate.c
    > +++ b/kernel/power/hibernate.c
    > @@ -663,9 +663,9 @@ int hibernate(void)
    > if (error)
    > goto Exit;
    >
    > - printk(KERN_INFO "PM: Syncing filesystems ... ");
    > + printk(KERN_INFO "PM: Syncing filesystems ...\n");
    > sys_sync();
    > - printk("done.\n");
    > + printk(KERN_INFO "PM: Syncing filesystems: done\n");
    >
    > error = freeze_processes();
    > if (error)
    >

    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2015-06-09 01:21    [W:19.236 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site