lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match.
Date
On Monday, June 08, 2015 10:31:00 AM Lukasz Majewski wrote:
> Hi Viresh,
>
> > On 25-05-15, 07:39, Shailendra Verma wrote:
> > > During probe free the memory allocated to "exynos_info" in case of
> > > unknown SOC type.
> > >
> > > Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> > > ---
> > > drivers/cpufreq/exynos-cpufreq.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/exynos-cpufreq.c
> > > b/drivers/cpufreq/exynos-cpufreq.c index 82d2fbb..8682378 100644
> > > --- a/drivers/cpufreq/exynos-cpufreq.c
> > > +++ b/drivers/cpufreq/exynos-cpufreq.c
> > > @@ -182,7 +182,7 @@ static int exynos_cpufreq_probe(struct
> > > platform_device *pdev) ret = exynos5250_cpufreq_init(exynos_info);
> > > } else {
> > > pr_err("%s: Unknown SoC type\n", __func__);
> > > - return -ENODEV;
> > > + ret = -ENODEV;
> > > }
> > >
> > > if (ret)
> > > @@ -190,12 +190,14 @@ static int exynos_cpufreq_probe(struct
> > > platform_device *pdev)
> > > if (exynos_info->set_freq == NULL) {
> > > dev_err(&pdev->dev, "No set_freq function
> > > (ERR)\n");
> > > + ret = -EINVAL;
> > > goto err_vdd_arm;
> > > }
> > >
> > > arm_regulator = regulator_get(NULL, "vdd_arm");
> > > if (IS_ERR(arm_regulator)) {
> > > dev_err(&pdev->dev, "failed to get resource
> > > vdd_arm\n");
> > > + ret = -EINVAL;
> > > goto err_vdd_arm;
> > > }
> > >
> > > @@ -227,7 +229,7 @@ err_cpufreq_reg:
> > > regulator_put(arm_regulator);
> > > err_vdd_arm:
> > > kfree(exynos_info);
> > > - return -EINVAL;
> > > + return ret;
> > > }
> > >
> > > static struct platform_driver exynos_cpufreq_platdrv = {
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>

I'm assuming that it will go it through the Samsung tree.


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.


\
 
 \ /
  Last update: 2015-06-09 01:21    [W:0.040 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site