lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][V3] usb: isp1760: check for null return from kzalloc
On Wed, Jun 03, 2015 at 03:43:23AM +0300, Laurent Pinchart wrote:
> Hi Colin,
>
> Thank you for the patch.
>
> On Tuesday 02 June 2015 19:05:13 Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > isp1760_ep_alloc_request allocates a structure with kzalloc without checking
> > for NULL and then returns a pointer to one of the structure fields. As the
> > field happens to be the first in the structure the caller can properly
> > check for NULL, but this is risky if the structure layout is changed later.
> > Add an explicit NULL check for the kzalloc return value
> >
> > Detected with smatch static analysis:
> >
> > drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
> > error: potential null dereference 'req'. (kzalloc returns null)
> >
> > [ thanks to Laurent Pinchart for improved commit message ]
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Felipe, I expect you to pick this up, please let me know if there's any issue.

I'll just take it directly, thanks.

greg k-h


\
 
 \ /
  Last update: 2015-06-08 23:41    [W:0.057 / U:2.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site