Messages in this thread | | | Date | Mon, 8 Jun 2015 13:57:03 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/2] debugfs: support read-only and write-only bool types |
| |
On Fri, Jun 05, 2015 at 05:42:55PM +0100, Mark Brown wrote: > On Fri, Jun 05, 2015 at 03:34:45PM +0100, Richard Fitzgerald wrote: > > > +static ssize_t debugs_read_wo_file(struct file *file, char __user *buf, > > + size_t count, loff_t *ppos) > > +{ > > + return -EACCES; > > +} > > Perhaps I'm missing something but shouldn't we be able to just omit > empty functions like this (this seems to be what the other ro/wo debugfs > defintions do otherwise these would already be there and it's what I'd > expect)?
Yes you should.
| |