[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] oom: split out forced OOM killer
On Mon, 8 Jun 2015, Austin S Hemmelgarn wrote:

> I believe so (haven't actually read the patch itself, just the changelog),
> although it is only a change for certain configurations to a very specific and
> (I hope infrequently) used piece of functionality. Like I said above, if I
> wanted to crash my system, I'd be using sysrq-c; and if I'm using sysrq-f, I
> want _some_ task to die _now_.

This patch is not a functional change, so I don't interpret your feedback
as any support of it being merged.

That said, you raise an interesting point of whether sysrq+f should ever
trigger a panic due to panic_on_oom. The case can be made that it should
ignore panic_on_oom and require the use of another sysrq to panic the
machine instead. Sysrq+f could then be used to oom kill a process,
regardless of panic_on_oom, and the panic only occurs if userspace did not
trigger the kill or the kill itself will fail.

I think we should pursue that direction.

This patch also changes the text which is output to the kernel log on
panic, which we use to parse for machines that have crashed due to no
killable memcg processes, so NACK on this patch. There's also no reason
to add more source code to try to make things cleaner when it just
obfuscates the oom killer code more than it needs to (we don't need to
optimize or have multiple entry points).

 \ /
  Last update: 2015-06-08 22:21    [W:0.037 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site