Messages in this thread |  | | Date | Mon, 8 Jun 2015 12:39:33 -0700 | Subject | Re: [PATCH v3 5/6] arch: introduce memremap_cache() and memremap_wt() | From | Dan Williams <> |
| |
On Mon, Jun 8, 2015 at 12:04 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Mon, Jun 8, 2015 at 9:25 PM, Dan Williams <dan.j.williams@intel.com> wrote: > >>>> + if (region_is_ram(offset, size) != 0) { >>>> + WARN_ONCE(1, "memremap attempted on ram %pa size: %zd\n", >>> >>> %zu >> >> Sure, thanks for taking a look Andy! > > One more thing, can we do > WARN_ONCE(region_is_ram(offset, size), …); ? >
We still want to return false in this case so it would become "if(WARN_ONCE(...)) return false;". Neil once made the argument to me that we should be able to compile all of the asserts out of the kernel, also "if (WARN_ONCE(...))" is a bit harder to read as you need to go check the macro to make sure it returns the right status, and more than once.
|  |