Messages in this thread |  | | Date | Mon, 8 Jun 2015 21:35:14 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON() |
| |
* Alexander Holler <holler@ahsoftware.de> wrote:
> Am 08.06.2015 um 13:27 schrieb Ingo Molnar: > > > >* Alexander Holler <holler@ahsoftware.de> wrote: > > > >>>I am pretty certain that Greg would have applied such a patch in an eye blink. > >> > >>As you've said it, *probably*. But such a simple exit path as you're proposing > >>doesn't always exist. [...] > > > >As I said it's case by case. I discussed your example (which was a deficient patch > >for multiple reasons) but we'd be wasting everyone's time by discussion > >hypothethical situations. > > Sure it was a deficient patch, but still better than what existed for a year > long in the kernel [...]
... but it was still worse than the simple solution I suggested:
if (WARN_ON_ONCE(port->itty)) return;
again, the BUG_ON() you wanted to introduce was wrong on multiple grounds, then and now. Why are you still arguing about this?
> I just want to make clear that a brutforce slogan like BUG_ON is bad is bad,
I pointed out specific cases where a BUG_ON() is the right solution. They are rare. Stop misrepresenting my words.
Thanks,
Ingo
|  |