lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/asm/entry/32: Reinstate clearing of pt_regs->r8..r11 on EFAULT path

* Denys Vlasenko <dvlasenk@redhat.com> wrote:

> I broke this recently when I changed pt_regs->r8..r11 clearing logic
> in INT 80 code path.
>
> There is a branch from SYSENTER/SYSCALL code to INT 80 code:
> if we fail to retrieve arg6, we return EFAULT. Before this patch,
> in this case we don't clear pt_regs->r8..r11.
>
> This patch fixes this. The resulting code is smaller and simpler.

So how did you notice this bug - through actual info leak testing, or review?

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-06-08 09:21    [W:0.065 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site