[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away
On Fri, Jun 05, 2015 at 07:42:48PM +0100, Lee Jones wrote:
> Perhaps this is just personal preference, but ...


> Prevents this kind of nonsense:

> this->is->just.silly = fetch_silly_value(&pointer);
> if (!this->is->just.silly) {
> printk("Silly value failed: %d\n", this->is->just.silly);
> return this->is->just.silly;
> }

But we don't have any of that code? Well, one if statement where we
check config.init_data but that's it. A temporary does help with things
like the above but we're not doing that in this driver are we?
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2015-06-08 20:21    [W:1.810 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site