Messages in this thread |  | | Date | Mon, 8 Jun 2015 19:07:18 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away |
| |
On Fri, Jun 05, 2015 at 07:42:48PM +0100, Lee Jones wrote: > Perhaps this is just personal preference, but ...
Possibly...
> Prevents this kind of nonsense:
> this->is->just.silly = fetch_silly_value(&pointer); > if (!this->is->just.silly) { > printk("Silly value failed: %d\n", this->is->just.silly); > return this->is->just.silly; > }
But we don't have any of that code? Well, one if statement where we check config.init_data but that's it. A temporary does help with things like the above but we're not doing that in this driver are we? [unhandled content-type:application/pgp-signature] |  |