lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 15/18] ring_buffer: Allow to exit the ring buffer benchmark immediately
    On Fri,  5 Jun 2015 17:01:14 +0200
    Petr Mladek <pmladek@suse.cz> wrote:

    > It takes a while until the ring_buffer_benchmark module is removed
    > when the ring buffer hammer is running. It is because it takes
    > few seconds and kthread_should_terminate() is not being checked.
    >
    > This patch adds the check for kthread termination into the producer.
    > It uses the existing kill_test flag to finish the kthreads as
    > cleanly as possible.
    >
    > It disables printing the "ERROR" message when the kthread is going.
    >
    > Also it makes sure that producer does not go into the 10sec sleep
    > when it is being killed.

    This patch looks like something I may take regardless of the other
    patches (if it applies cleanly).

    As for the other patches, the ring buffer benchmark is just that, a
    benchmark that I use when making changes to the ring buffer. It's not
    something for production systems.

    What about just adding a depend on !LIVE_PATCHING to
    RING_BUFFER_BENCHMARK, or force it to shut down during patching.
    There's no reason to make it safe to be running when you patch the
    kernel. Just adds complexity to some simple code.

    -- Steve


    \
     
     \ /
      Last update: 2015-06-08 20:01    [W:4.888 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site