[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync
On Mon, Jun 08, 2015 at 03:16:41PM +0100, Nariman Poushin wrote:

> In light of this:

Please provide human readable descriptions for things, people don't
always read online and it at least means going to another program to
figure out what's being discussed.

> Would it be prudent to now make these WARN_ON? It seems like it's not
> worth taking the kernel down in the case where you are trying to sync to
> a non-existent cache for a peripheral. Of course it could be that the

This is nothing new on Linus' part, really - as he himself says. We're
being cautious here because we are often controlling devices like PMICs
and battery chargers where we're worried about physically damaging the
system if we get things too wrong, one thing that might possibly have
been happening here is that we've got very confused about what we're
doing with a critical system component. There's certainly a case for
having some handling that's less severe but it does need to be something
that people notice and which is conservative about interacting with the
device after it noticed the problem.

In any case, if you want to propose a code change then please submit a
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2015-06-08 20:01    [W:0.031 / U:1.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site