Messages in this thread |  | | From | David Binderman <> | Subject | RE: linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418: array index used before limits check ? | Date | Mon, 8 Jun 2015 16:40:46 +0000 |
| |
Hello there Thomas,
---------------------------------------- >> I can't think of a situation where, if an array index needs checking, then >> it should be checked *after* use. > > It does not check the array index. Read the complete code: > > for (k = 0; k < INTC_IRQPIN_REG_NR; k++) { > io[k] = platform_get_resource(pdev, IORESOURCE_MEM, k); > if (!io[k] && k < INTC_IRQPIN_REG_NR_MANDATORY) { > > The array bound is INTC_IRQPIN_REG_NR and the check about which that > tool complains has nothing to do with array bounds. Completely valid > code.
After a deeper look at the code, agreed. False positive by the tool.
I also checked the rest of the /irqchip/ directory for other messages by the tool and couldn't see anything else suspicious.
Regards
David Binderman
|  |