[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418: array index used before limits check ?
Hello there Thomas,

>> I can't think of a situation where, if an array index needs checking, then
>> it should be checked *after* use.
> It does not check the array index. Read the complete code:
> for (k = 0; k < INTC_IRQPIN_REG_NR; k++) {
> io[k] = platform_get_resource(pdev, IORESOURCE_MEM, k);
> if (!io[k] && k < INTC_IRQPIN_REG_NR_MANDATORY) {
> The array bound is INTC_IRQPIN_REG_NR and the check about which that
> tool complains has nothing to do with array bounds. Completely valid
> code.

After a deeper look at the code, agreed. False positive by the tool.

I also checked the rest of the /irqchip/ directory for other messages by
the tool and couldn't see anything else suspicious.


David Binderman

 \ /
  Last update: 2015-06-08 19:21    [W:0.043 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site