Messages in this thread | | | Date | Mon, 8 Jun 2015 09:20:12 -0700 (PDT) | From | Vikas Shivappa <> | Subject | Re: [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT |
| |
On Mon, 8 Jun 2015, Thomas Gleixner wrote:
> On Sat, 6 Jun 2015, Thomas Gleixner wrote: > >> On Thu, 4 Jun 2015, Vikas Shivappa wrote: >>> +static inline void intel_rdt_sched_in(void) >>> +{ >>> + if (static_key_false(&rdt_enable_key)) >>> + __intel_rdt_sched_in(); >> >> So if the enable_key is FALSE we call the RDT stuff? I might be >> missing something important, but this does not make any sense and I >> have to ask how that whole stuff has been tested. > > Bah. That static key API is really designed for maximal confusion. The > above is correct, but a comment might not be the worst thing.
Ah yes, - its also tested with debug prints. Will add comment.
Thanks, Vikas
> > Thanks, > > tglx >
| |