lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 2/8] kernel/trace/trace_events_filter.c: Use strreplace
On Thu,  4 Jun 2015 11:37:09 +0200
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> There's no point in starting over every time we see a ','...
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> kernel/trace/trace_events_filter.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> index ced69da0ff55..a987601d7b43 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -2075,7 +2075,7 @@ struct function_filter_data {
> static char **
> ftrace_function_filter_re(char *buf, int len, int *count)
> {
> - char *str, *sep, **re;
> + char *str, **re;
>
> str = kstrndup(buf, len, GFP_KERNEL);
> if (!str)
> @@ -2085,8 +2085,7 @@ ftrace_function_filter_re(char *buf, int len, int *count)
> * The argv_split function takes white space
> * as a separator, so convert ',' into spaces.
> */
> - while ((sep = strchr(str, ',')))
> - *sep = ' ';
> + strreplace(str, ',', ' ');

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

>
> re = argv_split(GFP_KERNEL, str, count);
> kfree(str);



\
 
 \ /
  Last update: 2015-06-08 18:21    [W:0.240 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site