lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] hrtimer: HRTIMER_STATE_ fixes
From
Date
On Mon, 2015-06-08 at 17:10 +0200, Oleg Nesterov wrote:
> On 06/08, Peter Zijlstra wrote:
> >
> > > I tend to agree, but I think its a pre-existing problem, not one
> > > introduced by my proposed patch.
> >
> > Something like this would fix that I think. It fully preserves
> > timer->state over hrtimer_start_range_ns().
>
> Yes, but I think we can do a bit better.
>
> Only for initial review, I need to re-check this...

I'm having a wee bit of bother spotting how you version is 'better'.

> And. I think that after you remove STATE_CALLBACK we can even kill
> timer->state altogether, but this is another story.

Ah, yes, we could introduce timerqueue_is_queued() which uses
RB_EMPTY_NODE(). Obviating the need for hrtimer::state entirely.



\
 
 \ /
  Last update: 2015-06-08 18:21    [W:0.222 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site