lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 4/4] scsi: ufs: probe and init of variant driver from the platform device
From
2015-06-08 1:27 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
> static int ufshcd_pltfrm_remove(struct platform_device *pdev)
> {
> struct ufs_hba *hba = platform_get_drvdata(pdev);
> + struct device_node *node = pdev->dev.of_node;
> + struct device_node *ufs_variant_node;
> + struct platform_device *ufs_variant_pdev;
> +
> + ufs_variant_node = of_get_next_available_child(node, NULL);
> +
> + if (!ufs_variant_node)
> + dev_dbg(&pdev->dev, "no ufs_variant_node found\n");
> + else
> + ufs_variant_pdev = of_find_device_by_node(ufs_variant_node);
>
> pm_runtime_get_sync(&(pdev)->dev);
> ufshcd_remove(hba);
> + module_put(ufs_variant_pdev->dev.driver->owner);

module_put() should only be called when ufs_variant sub-node exists
and hba->vops was found.
If ufs->vops == NULL or no ufs_variant sub-node exists, this line
causes uninitialized pointer dereference.

> return 0;
> }


\
 
 \ /
  Last update: 2015-06-08 17:21    [W:0.035 / U:1.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site