lkml.org 
[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver
Date
On 05 June 2015 18:50 Dmitry Torokhov wrote:

> Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver
> On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > Add OnKey driver support for DA9063
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > ---
> > The changes made in PATCH V3 have been taken from the DA9062 OnKey review
> > thread. Please see https://lkml.org/lkml/2015/4/29/406 for more information
> > on this.
> >
> > Version History
> >
> > Changes in V4
> > - No change, just a resend.
>
> Sorry for the delay.
>
> I took the liberty of rearranging the code a bit and converting it to
> devm* fully, does the version below still work for you?
>

Hi Dmitry,

No problem. Thank you for getting back to me and for taking the time to work
through this code.

Everything looks fine for me thank you.

Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>

I see now: in future I will make use of the devm_add_action() and use the devm*
properly & your changes have simplified the error handling and negated the need
for a .remove function. The devm release cleans up in reverse -- preserving
the free_irq() and cancel_delayed_work_sync() ordering ...

Regards,
Steve.

CC: Adam Ward <adam.ward.opensource@diasemi.com>

[...]



\
 
 \ /
  Last update: 2015-06-08 13:41    [W:0.095 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site