Messages in this thread | | | Date | Mon, 8 Jun 2015 13:17:58 +0300 | From | Antony Pavlov <> | Subject | Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1 |
| |
On Sun, 31 May 2015 02:18:26 +0200 Alban Bedel <albeu@free.fr> wrote:
> Add a DTS for TL-WR1043ND version 1 and allow to have it built in the > kernel to circumvent the broken u-boot found on these boards. > Currently only the UART, LEDs and buttons are supported. > > Signed-off-by: Alban Bedel <albeu@free.fr>
> --- /dev/null > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi
> +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts > @@ -0,0 +1,112 @@ > +/dts-v1/; > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > + > +#include "ar9132.dtsi" > + > +/ { > + compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132"; > + model = "TP-Link TL-WR1043ND Version 1"; > + > + alias { > + serial0 = "/ahb/apb/uart@18020000"; > + }; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x2000000>; > + }; > + > + extosc: oscillator { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <40000000>; > + }; > + > + ahb { > + apb { > + uart@18020000 { > + status = "okay"; > + }; > + > + pll-controller@18050000 { > + clocks = <&extosc>;
IMHO AR9132 SoC can't work without external oscilator.
Can we just move basic extosc declaration to SoC dt file (ar9132.dtsi)? So board dt file ar9132_tl_wr1043nd_v1.dts will contain only oscilator clock frequency value.
E.g.
ar9132.dtsi: ============
extosc: oscillator { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <40000000>; }; ... ahb { apb {
...
pll-controller@18050000 { ... clocks = <&extosc>; ...
ar9132_tl_wr1043nd_v1.dts: ==========================
... &extosc { clock-frequency = <40000000>; };
-- Best regards, Antony Pavlov
| |