lkml.org 
[lkml]   [2015]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] drivers: of/base: move of_init to driver_init
Date
On Tue, 19 May 2015 10:17:32 -0700
, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
wrote:
> On Tue, May 19, 2015 at 01:29:16PM +0100, Sudeep Holla wrote:
> > Hi Rob/Greg,
> >
> > On 14/05/15 15:28, Sudeep Holla wrote:
> > >Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> > >devices with an OF node") adds the symlink `of_node` for each device
> > >pointing to it's device tree node while creating/initialising it.
> > >
> > >However the devicetree sysfs is created and setup in of_init which is
> > >executed at core_initcall level. For all the devices created before
> > >of_init, the following error is thrown:
> > > "Error -2(-ENOENT) creating of_node link"
> > >
> > >Like many other components in driver model, initialize the sysfs support
> > >for OF/devicetree from driver_init so that it's ready before any devices
> > >are created.
> > >
> > >Fixes: 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> > > devices with an OF node")
> > >Suggested-by: Rob Herring <robh+dt@kernel.org>
> > >Cc: Grant Likely <grant.likely@linaro.org>
> > >Cc: Rob Herring <robh+dt@kernel.org>
> > >Cc: Pawel Moll <pawel.moll@arm.com>
> > >Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >
> > I assume one of you will pick this up if there are no further comments ?
>
> I will once things settle down...

I've picked it up. Yell if you'd prefer to take it by your tree.

g.


\
 
 \ /
  Last update: 2015-06-07 19:21    [W:0.452 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site