lkml.org 
[lkml]   [2015]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses
From
From: Julien Grall <julien.grall@citrix.com>
Date: Thu, 4 Jun 2015 16:35:13 +0100

> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
>
> Also use %d rather than %x for rx->offset.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: netdev@vger.kernel.org
>
> ---
> Changes in v3:
> - Use %d for the rx-offset too.

This change in v3 is wrong, 'rx->offset' is unsigned therefore %u is
the correct format string to use.


\
 
 \ /
  Last update: 2015-06-07 11:21    [W:0.036 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site