[lkml]   [2015]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] cosa: use msecs_to_jiffies for conversions
From: Nicholas Mc Guire <>
Date: Sat, 6 Jun 2015 09:51:51 +0200

> @@ -517,7 +517,7 @@ static int cosa_probe(int base, int irq, int dma)
> */
> set_current_state(TASK_INTERRUPTIBLE);
> cosa_putstatus(cosa, SR_TX_INT_ENA);
> - schedule_timeout(30);
> + schedule_timeout(msecs_to_jiffies(300));
> irq = probe_irq_off(irqs);
> /* Disable all IRQs from the card */
> cosa_putstatus(cosa, 0);

You are making these transformations completely inconsistently.

You're converting it to msecs in some patches and here you are doing
something else.

Please do _all_ of these transformations consistently and in a way
that minimizes the chances of breaking things.

And the only way to do that is to strictly convert these cases to
whatever it works out to when HZ=100 since that is strictly the
environment all of this old code was written in.

Thank you.

 \ /
  Last update: 2015-06-07 09:41    [W:0.064 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site