lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement ,
Send the patch to yourself.  Apply it with git am.  Review the git log
and then send it to the list.

But actually this change is not correct at all. The prefered style in
staging is that multi-line indent blocks get curly braces for
readability even when they are not required by the compiler. The patch
introduces other coding style violations. Did you run checkpatch.pl
over it?

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-06-06 17:01    [W:0.033 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site